cobalt: Add LevelDB errors to Local Storage UMA#10006
Open
zhongqiliang wants to merge 3 commits intoyoutube:mainfrom
Open
cobalt: Add LevelDB errors to Local Storage UMA#10006zhongqiliang wants to merge 3 commits intoyoutube:mainfrom
zhongqiliang wants to merge 3 commits intoyoutube:mainfrom
Conversation
Change-Id: If0e6d33b3906f3964f888d1e2c7388e4c01f57ec
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Change-Id: I2c35cf07acde1740e513e57bb5584ce2154ecbf1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several new UMA histograms to track LevelDB errors during database open, read, commit, and version mismatch operations in Local Storage. Feedback indicates that the DatabaseOpenError histogram is redundant because the status is already recorded elsewhere. Furthermore, the DatabaseVersionMismatch histogram currently logs an 'OK' status in all cases, so it should be replaced with a more descriptive metric type like a boolean or a specific mismatch enum.
johnxwork
reviewed
Apr 14, 2026
Contributor
johnxwork
left a comment
johnxwork
left a comment
There was a problem hiding this comment.
Did you verify that you can see the data locally with the script in cobalt/tools/ to pull UMA?
Change-Id: Iebdc64f9aeccd244a2ebfde747f72ced63b7361c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous UMA metrics for Local Storage recreate or reset events
did not provide specific error codes. This made it challenging to
diagnose the root causes of database issues.
This change introduces new UMA histograms to capture detailed LevelDB
error statuses when failures occur during Local Storage database open,
read operations, schema version checks, and commit operations. These
specific error codes will provide better insight into the reasons
behind database recreation attempts, improving debuggability and
monitoring.
Bug: 488465561